[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: new snapshot available: coreutils-8.20.119-54cdb0

From: Pádraig Brady
Subject: Re: new snapshot available: coreutils-8.20.119-54cdb0
Date: Tue, 12 Feb 2013 09:18:34 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120615 Thunderbird/13.0.1

On 02/12/2013 04:45 AM, Assaf Gordon wrote:
On Feb 11, 2013, at 20:32, Pádraig Brady <address@hidden> wrote:

On 02/11/2013 08:47 PM, Assaf Gordon wrote:
-  if (errno != 0)
+  /* EINVAL can happen if 'base' is invalid (hardcoded as 10, so can't happen),
+     or if no conversion was performed (on some platforms). Ignore & continue
+     if no conversion was performed */
+  if (errno != 0 && (errno != EINVAL))

It might be better to do:

if (errno == ERANGE)
  error ();

In any case thanks for the fix.

I was thinking about that, my only concern was since we're already dealing with 
non-standard code, should we worry about an even weirder implementation that 
might return something that's not ERANGE and not EINVAL?

The error message is just about ERANGE, so it's probably
best to use just that value in the conditional.
Reading the docs, EINVAL is the only other possibility.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]