[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: uniq with sort-like "--key" support

From: Jim Meyering
Subject: Re: uniq with sort-like "--key" support
Date: Wed, 13 Feb 2013 18:05:08 +0100

Assaf Gordon wrote:
> Assaf Gordon wrote, On 02/13/2013 11:45 AM:
>> One more update with two changes:
> From: Assaf Gordon <address@hidden>
> Date: Mon, 11 Feb 2013 20:19:31 -0500
> Subject: [PATCH 01/12] uniq: support sort-like '--key' specification
> ---
>  src/uniq.c             |  338 ++++++++++++----
>  src/uniq_sort_common.h | 1096 
> ++++++++++++++++++++++++++++++++++++++++++++++++

Hi Gordon.
Thanks a lot for working on this long-requested change.
I don't have time to review it, but please change the name of that
new header file.  First, we use hyphens (not underscores) in file names.
Did you consider any names that evoke "key spec parsing"?
Then, the name would still be apropos if someday it's used by a program
other than sort and uniq.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]