[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] maint: choose editor for our commit-msg git hook the sam
Re: [PATCH 2/2] maint: choose editor for our commit-msg git hook the same way git does
Sat, 16 Feb 2013 12:10:14 +0100
On 02/16/2013 11:31 AM, Bernhard Voelker wrote:
> Hi Stefano,
> On 02/16/2013 07:16 AM, Stefano Lattarini wrote:
>> Hi Bernhard.
>> On 02/15/2013 04:54 PM, Bernhard Voelker wrote:
>>> Strange, when I provoke a 2nd re_edit() by giving a bad commit
>>> message, then "Vim" is used as $editor instead my $GIT_EDITOR
>>> (which has been successfully used in the first place).
>> Have you re-run ./bootstrap to cause the updated hook to be
>> installed in .git/hooks?
> I only updated .git/hooks/commit-msg without any "make" or
> "bootstrap". And this is what I did:
> In an xterm:
> $ ls >> src/df.c
> $ git add src/df.c
> $ git commit
> Then my $GIT_EDITOR opens as expected.
> I enter "hello world." as commit message and quit.
> ==> Then, vi is started in that xterm with the complaint
> line at the top to fix the commit message.
> After that, my xterm is totally messed up and only "reset"
That's what was happening to me *before* my patch. Now it no
longer does, for me at least (I tested it). Weird.
> Hmm, may it's my git version?
> $ git --version
> git version 1.7.7
Unlikely, that version is not ancient. But just to be sure, you
could check whether the issue is still present with the latest
Git. My guess is that such an update won't change anything, though.
> Thank you & have a nice day,
Re: [PATCH 1/2] maint: don't reset PATH in out commit-msg git hook, Pádraig Brady, 2013/02/15