coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] improve 'autotools-install'


From: Stefano Lattarini
Subject: Re: [PATCH] improve 'autotools-install'
Date: Fri, 22 Feb 2013 08:30:07 +0100

On 02/22/2013 12:08 AM, Assaf Gordon wrote:
> 
> 2. Recent "pkg-config" has a cyclic requirement of "glib", explained in the 
> README [1]:
>    pkg-config depends on glib.  Note that glib build-depends on pkg-config,
>    but you can just set the corresponding environment variables (ZLIB_LIBS,
>    ZLIB_CFLAGS are the only needed ones when this is written) to build it.
>
>    If this requirement is too cumbersome, a bundled copy of a recent glib
>    stable release is included. Pass --with-internal-glib to configure to
>    use this copy.
> 
I think this explanation should go in the commit message of the second patch,
as it makes clear why such patch is needed.

> The second patch adds this "--with-internal-glib" flag when configuring 
> pkg-config .
> 
> Sadly, autotools-install still doesn't complete, because gettext0.18.1
> fails to compile with stpncpy() related problem (exactly as solved in
> coreutils [2]) but that's is not a coreutil bug.
>
Is the issue still present with the latest gettext version (1.18.2)?  If not,
you could update the '$tarballs' definition to point to that instead.

Also, I see that the Automake version referenced by '$tarballs' is still
1.12.3; I think it should be updated to the latest available version
(1.13.2 at the moment of writing).

> -gordon
> 
> [1] http://cgit.freedesktop.org/pkg-config/tree/README?id=pkg-config-0.27.1
> [2] http://bugs.gnu.org/13495
> 

Thanks,
  Stefano



reply via email to

[Prev in Thread] Current Thread [Next in Thread]