[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: uniq: add "--group" option

From: Pádraig Brady
Subject: Re: [PATCH]: uniq: add "--group" option
Date: Thu, 28 Feb 2013 01:16:32 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 02/21/2013 07:40 PM, Assaf Gordon wrote:
> Assaf Gordon wrote, On 02/21/2013 11:37 AM:
>> You were planning on "--group" to mean explicitly "output all input lines, 
>> and add group-markers for unique groups" (meaning -u/-d/-D and --group are 
>> mutually exclusive).
> Attached is a version that behaves as previously discussed.
> "--group" can't be used with -c/-d/-D/-u.
> Since it's a completely separate behavior, I found it easier to create a 
> whole new code path in "check_file()" for the special case of grouping.
> Comments are welcomed,
>  -gordon

I'll push this tomorrow with the attached changes.
I added NEWS, docs and refactored the
default and --group core loops together as
as they're essentially the same.


Attachment: uniq--group--adjustments.diff
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]