[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH]: uniq: add tests for "--ignore-case"

From: Pádraig Brady
Subject: Re: [PATCH]: uniq: add tests for "--ignore-case"
Date: Thu, 28 Feb 2013 03:38:11 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 02/12/2013 03:44 PM, Assaf Gordon wrote:
> Hello,
> Attached are three small tests for uniq with "--ignore-case" (they pass, the 
> option was simply not tested before).


> Also,
> I noticed that by running the default test suite ("make check SUBDIRS=."), 
> the majority of uniq tests are skipped:
>   uniq: skipping this test -- no appropriate locale
>   SKIP: tests/misc/
>   PASS: tests/misc/
> This is due to tests/misc/ line 83:
>  83 # I've only ever triggered the problem in a non-C locale.                 
>  84 my $locale = $ENV{LOCALE_FR};                                             
>  85 ! defined $locale || $locale eq 'none'                                    
>  86   and CuSkip::skip "$prog: skipping this test -- no appropriate 
> locale\n";      
> which skips the entire suite if there's no french locale defined, even though 
> only one test actually sets the locale.
> I can have a patch for it, if that's acceptable.

Thanks for noticing that.
A patch would be much appreciated.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]