[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] maint: avoid a valgrind memory leak warning from pinky

From: Pádraig Brady
Subject: [PATCH] maint: avoid a valgrind memory leak warning from pinky
Date: Wed, 10 Jul 2013 01:15:28 +0100

Similarly to commit v8.21-84-g8d2da3f in src/uptime.c
avoid a "definitely lost" error from valgrind.  Note this
only happens with pinky when compiled without optimization,
in which case certain paths aren't eliminated casuing
valgrind to trigger the message.  Note also that coverity
flags this "resource leak" too.

* src/pinky.c (short_pinky): free utmp_buf for developer builds.
 src/pinky.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/src/pinky.c b/src/pinky.c
index e6838ae..500f70a 100644
--- a/src/pinky.c
+++ b/src/pinky.c
@@ -466,12 +466,14 @@ short_pinky (const char *filename,
              const int argc_names, char *const argv_names[])
   size_t n_users;
-  STRUCT_UTMP *utmp_buf;
+  STRUCT_UTMP *utmp_buf = NULL;
   if (read_utmp (filename, &n_users, &utmp_buf, 0) != 0)
     error (EXIT_FAILURE, errno, "%s", filename);
   scan_entries (n_users, utmp_buf, argc_names, argv_names);
+  IF_LINT (free (utmp_buf));
 static void

reply via email to

[Prev in Thread] Current Thread [Next in Thread]