[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: fix a memory leak in df

From: Bernhard Voelker
Subject: Re: [PATCH] maint: fix a memory leak in df
Date: Fri, 12 Jul 2013 12:42:22 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5

On 07/12/2013 12:32 PM, Pádraig Brady wrote:
> On 07/12/2013 11:30 AM, Bernhard Voelker wrote:
>> On 07/11/2013 02:53 PM, Pádraig Brady wrote:
>>> Attached.  Note it's updated to free _all_ discarded mount items,
>>> not just those being replaced.
>> Hi Padraig,
>> sorry to be late.
>> What do you think about the following patch to give the
>> discard_me variable a better scope?
> I considered that, but thought it clearer
> to avoid the 'continue'.

Okay, no big deal then.

BTW: what do you think about the 'still reachable' leaks denoted
by valgrind?  Depending on the case, the lists 'mount_list',
'table' and the variables 'stats' and 'columns' are not free()d.
Avoiding that IF_LINT()-ed wouldn't be too hard.

Have a nice day,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]