Re: [PATCH 2/2] shred: write larger chunks when possible

[Pádraig Brady]

On 11/04/2013 11:14 PM, Pádraig Brady wrote:

> +/*
> + * Determine if pattern type is periodic or not.
> + */
> +static bool
> +periodic_pattern (int type)
> +{
> +  if (type <= 0)
> +    return false;
> +
> +  char r[3];
> +  unsigned int bits = type & 0xfff;
> +
> +  bits |= bits << 12;
> +  r[0] = (bits >> 4) & 255;
> +  r[1] = (bits >> 8) & 255;
> +  r[2] = bits & 255;
> +
> +  return (r[0] != r[1]) || (r[0] != r[2]) || (r[1] != r[2]);
> +}

The r[1] != r[2] check is redundant of course.

I'll push this set later on as it should be uncontentious.

thanks,
Pádraig.