[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] mkfifo, mknod: avoid duplicate quoting in error diagnostic
From: |
Bernhard Voelker |
Subject: |
Re: [PATCH] mkfifo, mknod: avoid duplicate quoting in error diagnostic |
Date: |
Mon, 02 Dec 2013 15:26:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 |
On 12/02/2013 12:59 PM, Pádraig Brady wrote:
> On 12/02/2013 10:53 AM, Bernhard Voelker wrote:
>> - error (0, errno, _("cannot set permissions of `%s'"),
>> + error (0, errno, _("cannot set permissions of %s"),
>> quote (argv[optind]));
>
> +1
>
> This might benefit from a syntax check?
> Something along the lines of: git grep "[\`']%s'" src/*.c
Actually, I used something similar from the TODO file. ;-)
And yes, a syntax check rule makes sense. I'll prepare this
together with the other cleanups needed to make the new rule
pass:
git grep "[\`']%.'" src/*.c | cat
src/csplit.c: _("%s: closing delimiter '%c' missing"), str, delim);
src/df.c: error (0, 0, _("option --output: field '%s' unknown"), s);
src/df.c: error (0, 0, _("option --output: field '%s' used more than
once"),
src/mkfifo.c: error (0, errno, _("cannot set permissions of `%s'"),
src/mknod.c: error (EXIT_FAILURE, errno, _("cannot set permissions of `%s'"),
src/numfmt.c: devmsg ("simple_strtod_human:\n input string: '%s'\n "
src/numfmt.c: "locale decimal-point: '%s'\n", input_str,
decimal_point);
src/numfmt.c: msgid = N_("value too large to be converted: '%s'");
src/numfmt.c: msgid = N_("invalid number: '%s'");
src/numfmt.c: msgid = N_("rejecting suffix in input: '%s' (consider using
--from)");
src/numfmt.c: msgid = N_("invalid suffix in input: '%s'");
src/numfmt.c: msgid = N_("missing 'i' suffix in input: '%s' (e.g
Ki/Mi/Gi)");
src/numfmt.c: devmsg (" returning value: '%s'\n", buf);
src/numfmt.c: error (EXIT_FAILURE, 0, _("invalid unit size: '%s'"),
n_string);
src/numfmt.c:FORMAT must be suitable for printing one floating-point argument
'%f'.\n\
src/numfmt.c: " prefix: '%s'\n suffix: '%s'\n",
src/numfmt.c: error (conv_exit_code, 0, _("invalid suffix in input '%s':
'%s'"),
src/numfmt.c: devmsg ("formatting output:\n value: %Lf\n humanized: '%s'\n",
val, buf);
src/numfmt.c: devmsg (" After padding: '%s'\n", padding_buffer);
src/numfmt.c: devmsg ("trimming suffix '%s'\n", suffix);
src/numfmt.c: error (0, 0, _("large input value '%s': possible precision
loss"), p);
src/numfmt.c: devmsg ("extracting Fields:\n input: '%s'\n field: %d\n",
line, _field);
src/numfmt.c: devmsg (" TOO FEW FIELDS!\n prefix: '%s'\n", *_prefix);
src/numfmt.c: devmsg (" prefix: '%s'\n number: '%s'\n suffix: '%s'\n",
src/numfmt.c: error (EXIT_FAILURE, 0, _("invalid padding value
'%s'"), optarg);
src/numfmt.c: error (EXIT_FAILURE, 0, _("invalid field value '%s'"),
optarg);
src/numfmt.c: error (EXIT_FAILURE, 0, _("invalid header value
'%s'"),
src/od.c: error (0, 0, _("invalid character '%c' in type string %s"),
src/od.c: _("invalid output address radix '%c';\
src/stat.c: /* Add 2 to accommodate our conversion of the stat '%s' format
string
Thanks!
Have a nice day,
Berny
- [PATCH] mkfifo,mknod: avoid duplicate quoting in error diagnostic, Bernhard Voelker, 2013/12/02
- Re: [PATCH] mkfifo, mknod: avoid duplicate quoting in error diagnostic, Pádraig Brady, 2013/12/02
- Re: [PATCH] mkfifo, mknod: avoid duplicate quoting in error diagnostic,
Bernhard Voelker <=
- Re: [PATCH] mkfifo, mknod: avoid duplicate quoting in error diagnostic, Bernhard Voelker, 2013/12/02
- Re: [PATCH] mkfifo, mknod: avoid duplicate quoting in error diagnostic, Pádraig Brady, 2013/12/02
- Re: [PATCH] mkfifo, mknod: avoid duplicate quoting in error diagnostic, Bernhard Voelker, 2013/12/03
- Re: [PATCH] mkfifo, mknod: avoid duplicate quoting in error diagnostic, Pádraig Brady, 2013/12/03
- Re: [PATCH] mkfifo, mknod: avoid duplicate quoting in error diagnostic, Bernhard Voelker, 2013/12/03