[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] use libcrypto routines in gnulib

From: Pádraig Brady
Subject: Re: [PATCH] use libcrypto routines in gnulib
Date: Tue, 03 Dec 2013 13:45:10 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 12/03/2013 06:24 AM, Paul Eggert wrote:
> Pádraig Brady wrote:
>> Seems the handiest way to do this is to do the following
>> in before gl_INIT:
>> dnl Enable use of libcrypto by default
>> AC_ARG_WITH([openssl],
>>   [AS_HELP_STRING([--with-openssl],
>>     [use libcrypto hash routines if available: default=yes])],
>>   [],
>>   [with_openssl=yes])
> Unfortunately with Emacs this causes "configure --help" to output
> two disagreeing lines for --with-openssl; one incorrect
> one, put out by the AC_ARG_WITH in m4/gl-openssl.m4,
> and one correct one, put out by the above call.

Ugh, It's a pity one can't nicely override AC_ARG_WITH.
It seems that the first use of --with[out]-whatever
should take precedence.

I'll probably do this in coreutils before gl_INIT,
so as to at least set the default as coreutils wants and caters for,
and allowing users to --without-openssl if they want.

dnl Enable use of libcrypto by default
AS_VAR_SET_IF([with_openssl], [], [with_openssl=maybe])

> Come to think of it, the GNU coding standards say that
> --with-openssl should configure the system to use the
> OpenSSL library (and fail if it's not available, presumably;
> that's what gl_GC and gl_LIBSELINUX do), but the recently-added
> code doesn't do that; it issues a warning and disables the
> library instead.  Maybe we should be more consistent with
> the rest of Gnulib here?

Hmm, I don't think the above mentioned fail if not available?
I'm using "maybe" above anyway, so that "yes" may be
treated like this in future.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]