Re: deadlock in with fifo reading in tests/dd/no-allocate.sh

[Pádraig Brady]

On 12/12/2013 01:34 PM, Bernhard Voelker wrote:
> On 12/11/2013 11:24 AM, Pádraig Brady wrote:
>>> The question is which of the tests hung?
>>> The input (i.e. skip) or the output (i.e. seek) tests?
>>
>> I think it was the last dd, though can't be sure as
>> the net connection died as I was debugging.
> 
> Sorry, I couldn't reproduce it either, and the test code
> looks good to me.  Could it have been a shell issue?

Probably a shell bug.
So what I've done is avoided the shell writing to the fifo.
Also I've added timeouts to be defensive.
Also I added a `wait` to avoid overlapping writers to the fifo.

I tested this test passes without delay on GNU/Linux, Solaris and FreeBSD.

The attached should hopefully be the last change before the release.

thanks,
Pádraig.

dd-no-allocate-race.patch
Description: Text Data