coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[heads-up] patch re. savedir() in src/copy.c needed when updating gnulib


From: Bernhard Voelker
Subject: [heads-up] patch re. savedir() in src/copy.c needed when updating gnulib
Date: Wed, 26 Feb 2014 18:25:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.3.0

Due to a gnulib commit [1] the function savedir() has one more
argument (the corresponding discussion was in [2]).

I.e. when updating gnulib the next time, then a patch like the
following will necessary:


diff --git a/src/copy.c b/src/copy.c
index 0b7c59e..6f9c626 100644
--- a/src/copy.c
+++ b/src/copy.c
@@ -598,7 +598,7 @@ copy_dir (char const *src_name_in, char const *dst_name_in, 
bool new_dst,
   struct cp_options non_command_line_options = *x;
   bool ok = true;

-  name_space = savedir (src_name_in);
+  name_space = savedir (src_name_in, SAVEDIR_SORT_NONE);
   if (name_space == NULL)
     {
       /* This diagnostic is a bit vague because savedir can fail in

Possible other values are SAVEDIR_SORT_NAME and SAVEDIR_SORT_INODE,
but I assume that ..._NONE is okay for the use in copy_dir().

Have a nice day,
Berny

[1] http://git.sv.gnu.org/cgit/gnulib.git/commit/?id=be7d7370
[2] http://lists.gnu.org/archive/html/bug-gnulib/2014-02/msg00007.html



reply via email to

[Prev in Thread] Current Thread [Next in Thread]