[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: dd SIGUSR1 race

From: Bernhard Voelker
Subject: Re: dd SIGUSR1 race
Date: Thu, 02 Oct 2014 02:38:05 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0

On 09/30/2014 02:17 PM, Pádraig Brady wrote:
Subject: [PATCH] dd: new status=progress level to print stats periodically

Thanks, that looks great now!

Minor nit - see the trivial patch below.

Thanks & have a nice day,

From 4f87ca916c6b42a5b8a10ce7bc4e54f2ba06451c Mon Sep 17 00:00:00 2001
From: Bernhard Voelker <address@hidden>
Date: Thu, 2 Oct 2014 02:34:48 +0200
Subject: [PATCH] maint: avoid double semicolon syntax check failure

A syntax-check recently added to gnulib would trigger a failure
(once gnulib gets updated here) for a statement introduced with
commit v8.23-43-gaf2a4ed:

  src/dd.c:806:  char const *time_fmt = _(", %g s, %s/s\n");; Double semicolon detected
  make: *** [sc_prohibit_double_semicolon] Error 1

* src/dd.c (print_xfer_stats): s/;;/;/
 src/dd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/dd.c b/src/dd.c
index 4018190..78433ff 100644
--- a/src/dd.c
+++ b/src/dd.c
@@ -803,7 +803,7 @@ print_xfer_stats (xtime_t progress_time) {
      but that was incorrect for languages like Polish.  To fix this
      bug we now use SI symbols even though they're a bit more
      confusing in English.  */
-  char const *time_fmt = _(", %g s, %s/s\n");;
+  char const *time_fmt = _(", %g s, %s/s\n");
   if (progress_time)
     time_fmt = _(", %.6f s, %s/s");  /* OK with '\r' as increasing width.  */
   fprintf (stderr, time_fmt, delta_s, bytes_per_second);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]