[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: avoid false failure when comparing /proc/cpuinfo

From: Bernhard Voelker
Subject: Re: [PATCH] tests: avoid false failure when comparing /proc/cpuinfo
Date: Thu, 16 Oct 2014 12:18:13 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0

On 10/16/2014 11:51 AM, Pádraig Brady wrote:
BTW, I just noticed a separate issue while looking
at /proc usage in the tests, which the following should fix up.


commit 437f24764963ca2935e1bce368667f8270275a4b
Author: Pádraig Brady <address@hidden>
Date:   Thu Oct 16 10:33:46 2014 +0100

     tests: fix test hang with unstable inodes in /proc

     * cp/ Search the 'err' file
     for the error to ignore, not stdin.

diff --git a/tests/cp/ b/tests/cp/
index 3fcd5aa..8dd8460 100755
--- a/tests/cp/
+++ b/tests/cp/
@@ -31,7 +31,7 @@ cat $f > out || fail=1
  # number of the file changed during the cp run.
  cp $f exp 2>err \
    || { fail=1;
-       grep 'replaced while being copied' \
+       grep 'replaced while being copied' err \
           && skip_ "File $f is being replaced while being copied"; }

  # Don't simply compare contents; they might differ,

oops, that slipped in by my commit v8.22-6-gd134211, sorry.
The fix looks good, of course. Thanks!

Have a nice day,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]