coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] doc: mention that df -a includes duplicate file systems


From: Pádraig Brady
Subject: Re: [PATCH] doc: mention that df -a includes duplicate file systems
Date: Mon, 27 Oct 2014 14:12:05 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 10/27/2014 12:04 PM, Bernhard Voelker wrote:
> On 10/27/2014 12:49 PM, Pádraig Brady wrote:
>> diff --git a/doc/coreutils.texi b/doc/coreutils.texi
>> index aece931..03a4a33 100644
>> --- a/doc/coreutils.texi
>> +++ b/doc/coreutils.texi
>> @@ -11231,9 +11231,13 @@ The program accepts the following options.  Also 
>> see @ref{Common options}.
>>   @opindex --all
>>   @cindex automounter file systems
>>   @cindex ignore file systems
>> -Include in the listing dummy file systems, which
>> -are omitted by default.  Such file systems are typically special-purpose
>> -pseudo-file-systems, such as automounter entries.
>> +Include in the listing dummy, duplicate, or inaccessible file systems, which
>> +are omitted by default.  Dummy file systems are typically special purpose
>> +pseudo file systems such as @samp{/proc}, with no associated storage.
>> +Duplicate file systems are local or remote file systems that are mounted
>> +at separate locations in the local file hierarchy.  [...]
> 
> maybe mention bind mounts explicitly here?

done

>> [...]  Inaccessible file systems
>> +are those which are mounted but subsequently over-mounted by another
>> +file system at that point.
> 
> ... or otherwise inaccessible, e.g. if mounted on /root/mnt, then a normal
> user wouldn't see it.

done

>>   @item -B @var{size}
>>   @itemx address@hidden
>> diff --git a/src/df.c b/src/df.c
>> index ccb1f5e..3c8cc82 100644
>> --- a/src/df.c
>> +++ b/src/df.c
>> @@ -1396,7 +1396,7 @@ or all file systems by default.\n\
>>         /* TRANSLATORS: The thousands and decimal separators are best
>>            adjusted to an appropriate default for your locale.  */
>>         fputs (_("\
>> -  -a, --all             include dummy file systems\n\
>> +  -a, --all             include dummy and duplicate file systems\n\
>>     -B, --block-size=SIZE  scale sizes by SIZE before printing them; e.g.,\n\
>>                              '-BM' prints sizes in units of 1,048,576 
>> bytes;\n\
>>                              see SIZE format below\n\
>>
> 
> s/duplicate/otherwise elided/ ?

It's better to be explicit here. I think I'll go with the following:
(I noticed questions elsewhere as to what a dummy file system was):

  -a, --all             include pseudo, duplicate, inaccessible file systems\n\

> 
> While at df.c, you could also fix the "exsiting" typo in a comment.

done.

thanks,
Pádraig.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]