[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: make inotify-rotate more robust and efficient

From: Bernhard Voelker
Subject: Re: [PATCH] tests: make inotify-rotate more robust and efficient
Date: Wed, 29 Oct 2014 23:02:45 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0

On 10/29/2014 10:20 PM, Pádraig Brady wrote:
>> [  736s] + kill 24570
>> > [  736s] ./tests/tail-2/ line 65: kill: (24570) - No 
>> > such process
> I was wonderomg did the timeout 40 kill the tail process before it could 
> propagate the "ok"
> I.E. that something recent was slowing down this test causing the false 
> positives?
> Though the the above happened on the first time through the loop so that's 
> not likely.

That's the only possibility - on OBS it's extremely hard to predict
the load on CPU / disk, e.g. tests/rm/ is spuriously
failing because rm(1)'s duration exceeds 60 seconds (although we're
using 'make check-very-expensive' without -j N there) ... while it
takes only 14s locally.

However, your patch looks good.

Thanks & have a nice day,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]