[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: tests: fix comments about retry_delay_

From: Pádraig Brady
Subject: Re: [PATCH] maint: tests: fix comments about retry_delay_
Date: Wed, 29 Oct 2014 23:34:51 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2

On 10/29/2014 11:17 PM, Bernhard Voelker wrote:
> On 10/29/2014 10:30 PM, Pádraig Brady wrote:
>> On 10/29/2014 09:07 PM, Bernhard Voelker wrote:
>>> While looking at all uses of retry_delay_, I found that its return
>>> code is not evaluated in tests/du/ -
>>> it should read:
>>> - retry_delay_ nonempty .1 5
>>> + retry_delay_ nonempty .1 5 || fail=1
>> Good catch. Please push that patch.
> Thanks, pushed:
>>> A failure in another use during cleanup in tests/tail-2/
>>> does not have necessarily to be caught, but it would if we created a
>>> syntax-check for 'retry_delay_.*\|\|' ...
>> A syntax check for this is probably overkill.
>> This case would probably be better served by replacing the
>> cleanup() and associated retry_delay_() with a `wait`.
> I don't think so: I've also seen these .nfs-ABC123 files lurking
> around on NFS even a few seconds after the process had terminated,
> and the directory couldn't be deleted.

Interesting. Though we rely on the wait in as per:


reply via email to

[Prev in Thread] Current Thread [Next in Thread]