Re: [PATCH] tests: add extra protection against unexpected exits

[Pádraig Brady]

On 14/01/15 16:40, Bernhard Voelker wrote:
> On 01/14/2015 04:48 PM, Jim Meyering wrote:
>> On Wed, Jan 14, 2015 at 1:24 AM, Bernhard Voelker
>> <address@hidden> wrote:
>>> On 01/14/2015 02:51 AM, Pádraig Brady wrote:
>>>> -compare /dev/null err && fail=1
>>>> +test -s err || fail=1
>>>
>>> nice one!
>>
>> Actually, I prefer the former.
>> When some program produces unexpected output, that use of
>> compare-vs-/dev/null will ensure that the surprising output is
>> printed in the test's output. If you use only the "test -s err",
>> you would have to instrument and rerun in order to see
>> the offending output.
> 
> oops, you're right.
> 
> There were a few others, too.
> Fixed with the attached.

+1

thanks!
Pádraig