Re: PATCH: add xterm-termite to dircolors' supported termtypes

[Pádraig Brady]

On 20/01/15 12:41, Dario Giovannetti wrote:
> Hi, there's a VTE-based terminal emulator that does support ls colors, 
> but its termtype "xterm-termite" is not included in dircolors's 
> database: this patch simply adds it :)
> The terminal emulator's project page is at 
> https://github.com/thestinger/termite
> 
> Thank you,
> Dario
> 
> ##################################
>  From 88f29c740bf5b3ff0f256fb059a01ceab73e4849 Mon Sep 17 00:00:00 2001
> From: Dario Giovannetti <address@hidden>
> Date: Tue, 20 Jan 2015 20:29:05 +0800
> Subject: [PATCH] dircolors: add xterm-termite as a supported termtype
> 
> https://github.com/thestinger/termite
> ---
>   src/dircolors.hin | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/dircolors.hin b/src/dircolors.hin
> index 4b5067f..8d0c3e6 100644
> --- a/src/dircolors.hin
> +++ b/src/dircolors.hin
> @@ -65,6 +65,7 @@ TERM xterm-256color
>   TERM xterm-88color
>   TERM xterm-color
>   TERM xterm-debian
> +TERM xterm-termite
> 
>   # Below are the color init strings for the basic file types. A color init
>   # string consists of one or more of the following numeric codes:

Why did termite need to distinguish its terminal capabilities like this?
That $TERM will not work with lots of things. For example:

  $ TERM=xterm tput colors
  8

  $ TERM=xterm-termite tput colors
  tput: unknown terminal "xterm-termite"

I'd be more inclined to get termite to reconsider its TERM choice.

Pádraig