Re: factor-parallel test failure with SHELL=zsh

[Pádraig Brady]

On 02/07/15 17:46, Jim Meyering wrote:
> On Thu, Jul 2, 2015 at 4:57 AM, Pádraig Brady <address@hidden> wrote:
>> On 02/07/15 08:08, Pádraig Brady wrote:
>>> On 02/07/15 06:19, Jim Meyering wrote:
>>>> For me, an obvious work-around is to set SHELL=/bin/sh
>>>> or similar.
>>>
>>> Yes or to avoid the slight chance of /bin/sh also resetting the path
>>> you could directly reference the binary as follows.
>>> I slightly prefer setting the SHELL though.
>>
>> Yes given we should also set SHELL in tests/split/filter.sh,
>> I'll apply the attached in your name later on.
> 
> Thanks, but I would prefer to change init.sh to reject (or at least
> deprioritize) zsh in that case. I'll propose a patch soon.

Or I suppose any $SHELL so configured to reset the $PATH.
I suppose we'd need the change to the tests also in case
another shell was not found?

BTW if changing gl_shell_test_script_, what do you think about
the change to reject shells that don't support 'local'?

diff --git a/tests/init.sh b/tests/init.sh
index 9f403c5..c4dfadd 100755
--- a/tests/init.sh
+++ b/tests/init.sh
@@ -150,6 +150,7 @@ fi
 #  ? - not ok
 gl_shell_test_script_='
 test $(echo y) = y || exit 1
+f() { local v=1; }; f || exit 1
 score_=10
 if test "$VERBOSE" = yes; then
   test -n "$( (exec 3>&1; set -x; P=1 true 2>&3) 2> /dev/null)" && score_=9

cheers,
Pádraig.