[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] maint: ensure emit_mandatory_arg_note() used if needed
|
From: |
Bernhard Voelker |
|
Subject: |
Re: [PATCH] maint: ensure emit_mandatory_arg_note() used if needed |
|
Date: |
Wed, 16 Dec 2015 08:39:14 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 |
On 12/15/2015 06:45 PM, Pádraig Brady wrote:
> +# Ensure emit_mandatory_arg_note() is called if required
> +sc_ensure_emit_mandatory_arg_note:
> + @cd $(srcdir)/src && GIT_PAGER= git \
> + grep -l -- '^ *-[^-].*--.*[^[]=' *.c \
> + | xargs grep -L emit_mandatory_arg_note | grep . \
> + && { echo '$(ME): '"emit_mandatory_arg_note() missing" 1>&2; \
> + exit 1; } || :
> +
looks good.
I'd intuitively had searched the --help output instead of *.c,
but that's a matter of personal style. It seems yours doesn't
give a FP nor does it miss something. ;-)
Thanks!
Have a nice day,
Berny