Re: [platform-testers] new snapshot available: coreutils-8.24.150-4ab87

[Pádraig Brady]

On 14/01/16 03:37, Pádraig Brady wrote:
>> Does the test pass when changing s/1000/2000/ on the ulimit line?
>> > 
>>> >> FAIL: tests/misc/kill
>> > 
>>> >> + SIGINVAL=32
>>> >> + returns_ 1 env kill -l 32 0
>>> >> LWP
>>> >> EXIT
>>> >> + fail=1
>> > 
>> > This is a new test, and the scheme used to pick an
>> > invalid signal number is not general.
>> > I'll see if I can get sig2str() to return -1 generally.
> Looking further it seems that NSIG is only for older signals on FreeBSD
> and there is a newer _SIG_MAXSIG that we can add to gnulib like:
> 
> diff --git a/lib/sig2str.h b/lib/sig2str.h
> index f347170..2730774 100644
> --- a/lib/sig2str.h
> +++ b/lib/sig2str.h
> @@ -44,6 +44,8 @@ int str2sig (char const *, int *);
> 
>  #if defined _sys_nsig
>  # define SIGNUM_BOUND (_sys_nsig - 1)
> +#elif defined _SIG_MAXSIG
> +# define SIGNUM_BOUND (_SIG_MAXSIG - 2) /* FreeBSD >= 7.  */
>  #elif defined NSIG
>  # define SIGNUM_BOUND (NSIG - 1)
>  #else

Now in gnulib. Will sync with this soon:
http://git.sv.gnu.org/gitweb/?p=gnulib.git;a=commitdiff;h=dce117ac

> As for the test to get an invalid signal number, this would be more general:
> 
>   env kill -t | sort -k 1b,1 > sig.list
>   seq 256 | sort -k 1b,1 > all.list
>   invalid=$(join -v2 sig.list all.list | head -n1)
>   if test "$invalid"; then
>     ...
>   fi

Though a bit of overkill really.

> Related to this I also notice that we wrap signal specs
> which doesn't seem appropriate here:
> 
> $ bash-kill -l 257
> bash: kill: 257: invalid signal specification
> $ util-linux-kill -l 257
> kill: unknown signal: 257
> $ coreutils-kill -l 257
> HUP
> $ coreutils-kill -l 1
> HUP

A patch for both issues above attached.

thanks,
Pádraig

kill-large-signals.patch
Description: Text Data