[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Speeding up df
|
From: |
Bernhard Voelker |
|
Subject: |
Re: Speeding up df |
|
Date: |
Sun, 31 Jul 2016 21:41:59 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 |
On 07/25/2016 01:16 PM, Philipp Thomas wrote:
> Hi Bernie,
>
> * Bernhard Voelker (address@hidden) [20160724 23:33]:
>
>> Maybe adding an IF_LINT'ed hash_free call would be worth;
>> otherwise it looks good to me.
>
> I don't quite understand as filter_mount_list already does call hash_free at
> the end. So please explain.
hash_free is only called if (! devices_only), i.e., so not if the -a option
is passed. There are also other allocations not free()d in df.c. Maybe it'd
be good to guard them all with IF_LINT(...) for better maintainability: to
see what are real leaks and what is freed at exit anyway.
Have a nice day,
Berny