Re: avoid new GCC-7-exposed warnings

[Jim Meyering]

On Sat, Oct 15, 2016 at 3:57 PM, Pádraig Brady <address@hidden> wrote:
> On 15/10/16 18:11, Pádraig Brady wrote:
>> I'll do the follow up patch to use [die] in more places.
>
> A boring copy/replace patch:
> 84 files changed, 875 insertions(+), 800 deletions(-)
> (extra insertions are the inclusion of die.h)
>
> One interesting bit is a new syntax check:
>
> # Usage of error() with an constant to exit() with, should instead use die(),
> # as that avoids warnings and may generate better code, due to being apparent
> # to the compiler that it doesn't return.
> sc_die_EXIT_FAILURE:
>        @cd $(srcdir)/src && GIT_PAGER= git grep -E \
>            'error \(.*_(FAILURE|INVALID)' \
>          && { echo '$(ME): '"Use die() instead of error" 1>&2; \
>               exit 1; }  \
>          || :
>
> will push later...

Thanks.
Here's one more change I'll push today. It removes a few now-useless
calls to "abort" after die, and by a similar token, removes some
"break;" statements after abort:

cu-unreachable.diff
Description: Text document