[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] tail: only retry file open if --retry specifed
From: |
Jim Meyering |
Subject: |
Re: [PATCH] tail: only retry file open if --retry specifed |
Date: |
Thu, 10 Nov 2016 07:43:11 -0800 |
On Wed, Nov 9, 2016 at 11:40 AM, Pádraig Brady <address@hidden> wrote:
> * src/tail.c (tail_file): On failure to open a file,
> set ignore=true when --retry is not specified.
> * tests/tail-2/assert-2.sh: Adjust to the new behavior.
> * tests/tail-2/retry.sh: Add a test case.
> * NEWS: Document the fix.
> ---
> NEWS | 4 ++++
> src/tail.c | 2 +-
> tests/tail-2/assert-2.sh | 2 +-
> tests/tail-2/retry.sh | 18 ++++++++++++++++++
> 4 files changed, 24 insertions(+), 2 deletions(-)
>
> diff --git a/NEWS b/NEWS
> index d88fbd9..6dd6772 100644
> --- a/NEWS
> +++ b/NEWS
> @@ -63,6 +63,10 @@ GNU coreutils NEWS -*-
> outline -*-
> Previously truncation was ignored thus not outputting new data in the file.
> [bug introduced in coreutils-5.3.0]
>
> + tail -f will no longer continually try to open inaccessible files,
> + only doing so if --retry is specified.
> + [This bug was present in "the beginning".]
...
Oh! nice catch.
Looks all good.
Thank you!