[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] build: avoid racy failure of "make -jN install"
|
From: |
Eric Blake |
|
Subject: |
Re: [PATCH] build: avoid racy failure of "make -jN install" |
|
Date: |
Wed, 23 Nov 2016 05:18:56 -0600 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 |
On 11/23/2016 04:54 AM, Pádraig Brady wrote:
> On 23/11/16 05:36, Jim Meyering wrote:
>> diff --git a/src/local.mk b/src/local.mk
>> index 9e36ad9..37f625c 100644
>> --- a/src/local.mk
>> +++ b/src/local.mk
>> @@ -644,3 +644,4 @@ else
>> cu_install_program = src/ginstall
>> endif
>> INSTALL_PROGRAM = $(cu_install_program)
>> +INSTALL = $(cu_install_program) -c
>
> Why the -c ?
Because that's how automake usually defines INSTALL. Without the patch,
Makefile gets:
INSTALL = /usr/bin/install -c
INSTALL_DATA = ${INSTALL} -m 644
INSTALL_PROGRAM = ${INSTALL}
But that argues that maybe $(cu_install_program) should include the -c,
or that our override of INSTALL_PROGRAM is unneeded if we only override
INSTALL.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature