[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: avoid spurious "make distcheck" failure

From: Bernhard Voelker
Subject: Re: [PATCH] maint: avoid spurious "make distcheck" failure
Date: Wed, 21 Jun 2017 00:44:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1

On 06/20/2017 10:49 PM, Jim Meyering wrote:
> From a05ba352d39a6e6a0c58d57f4b7acbb1e4f11f8b Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Tue, 20 Jun 2017 07:53:17 -0700
> Subject: [PATCH] maint: avoid spurious "make distcheck" failure

> When the generated file, doc/constants.texi, happens to be older than
> doc/, it will not be updated until/unless its generated
> contents change.  This is due to way that rule is careful to update
> the file, to avoid provoking a pointless rerunning of makeinfo.
> Note that this does not happen when one first runs "make distclean",
> as recommended in README-release.  However, I sometimes run it as
> a more-rigorous "make check", and shouldn't have to manually run
> "make distclean" first, in that case.
> Before this change, one could reproduce the failure by running
> `touch -dyesterday doc/constants.texi && make distcheck`.  It would
> fail with "makeinfo: could not open ../../doc/
> for writing: Permission denied"
> * (dist-hook): Touch the two generated files, so that
> they are cannot be out of date wrt doc/coreutils.texi.

s/are //  # minor nit

Thanks & have a nice day,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]