[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Feature request: ls --hyperlink

From: Pádraig Brady
Subject: Re: Feature request: ls --hyperlink
Date: Sun, 27 Aug 2017 19:27:48 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 25/08/17 13:01, Egmont Koblinger wrote:
> Hi,
>> Version 2 [...]
>> ensures that URLs are aligned in padded output,
> I'm not sure I like this change (the outer pair of single quotes no longer 
> belonging to the URL).
> First, these single quotes are colored according to the file type. With this 
> change, coloring and URLizing became less consistent compared to each other.

I've just tested with src/testvte and I think
the alignment is better when not including the quotes in the URL.
I.E. the misaligned underlining is distracting.

Now this wouldn't be an issue if the URIs weren't highlighted by default.
When you have a block of URIs, having them all underlined (albeit dotted)
is noisy and would at least for me mean I wouldn't enable --hyperlink
by default for ls. It would be very useful for apps like ls to indicate
whether they wanted an indicator by default.
How about we support hl=# parameter, where 1 = hover only, 2 = both ?
I've updated the patch here to output the hl=1 parameter
and have confirmed that vte ignores it as expected at present.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]