coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] build: ls.c: apply _GL_ATTRIBUTE_PURE to more functions


From: Pádraig Brady
Subject: Re: [PATCH] build: ls.c: apply _GL_ATTRIBUTE_PURE to more functions
Date: Sun, 29 Oct 2017 14:25:37 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0

On 27/10/17 21:37, Jim Meyering wrote:
> I noticed a new warning/error when building with git-latest gcc,
> and propose to fix it with this:
> 
>>From f89c20bdf7ccc033cbc22662e932fae7761754fc Mon Sep 17 00:00:00 2001
> From: Jim Meyering <address@hidden>
> Date: Fri, 27 Oct 2017 21:14:37 -0700
> Subject: [PATCH] build: ls.c: apply _GL_ATTRIBUTE_PURE to more functions
> 
> * src/ls.c (DEFINE_SORT_FUNCTIONS): Apply _GL_ATTRIBUTE_PURE
> to each strcmp-derived function definition, since GCC8 with
> -Wsuggest-attribute=pure now warns it is needed.

+1
Works fine with gcc 6.3.1 FWIW

cheers,
Pádraig




reply via email to

[Prev in Thread] Current Thread [Next in Thread]