[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] maint: update gnulib to latest

From: Bernhard Voelker
Subject: Re: [PATCH] maint: update gnulib to latest
Date: Tue, 24 Jul 2018 08:45:59 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.0

On 07/21/2018 10:36 PM, Pádraig Brady wrote:
> On 19/07/18 10:22, Bernhard Voelker wrote:
>> On 06/25/2018 06:48 PM, Pádraig Brady wrote:
>>> `make gnulib-sync` would definitely be worth doing.
>> Done in the attached.  WDYT?
> I like it.  It works well here.

Minor nit (to my own patch):

>> Subject: [PATCH] maint: provide make target to update gnulib to latest
>> * (gnulib-sync, update-gnulib-to-latest): Add target to
>> pull the latest commit of the gnulib submodule, and also to copy over
>> the files we keep in sync; add them to the index as well.

The code doesn't do that.
As one has to do the commit manually later on anyway, I suggest to remove
that sentence from the commit message (instead of adding 'git add ...'
to the 'gnulib-sync' target).  Okay?

Thanks & have a nice day,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]