[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ls: issue error message on removed directory

From: Pádraig Brady
Subject: Re: [PATCH] ls: issue error message on removed directory
Date: Thu, 27 Feb 2020 14:20:28 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:73.0) Gecko/20100101 Thunderbird/73.0

On 12/02/2020 11:18, Pádraig Brady wrote:
On 11/02/2020 19:41, Pádraig Brady wrote:
On 11/02/2020 10:45, Colin Watson wrote:
If the current directory has been removed, then "ls" confusingly
produced no output and no error message, indistinguishable from the case
of running on an empty directory.  It makes more sense to report ENOENT
in this case.

I don't think this is a general solution as the opendir() spec states:
"The directory entries for dot and dot-dot are optional".
I've also seen reference to FUSE file systems that don't provide those entries.

In saying that, this is a common gotcha.
I wonder could we do something like:

+#ifdef __linux__
+      else if (! found_any_entries)
+        {
+          /* If readdir finds no directory entries at all, not even "." or
+             "..", then double check that the directory exists.  */
+          char buf[1024];
+          if (syscall(SYS_getdents, dirfd (dirp), buf, sizeof buf) == -1)
+            {
+              file_failure (command_line_arg, _("reading directory %s"), name);
+              break;
+            }
+        }

No objections so pushed at:;a=commitdiff;h=v8.31-88-g05a99f7d7


reply via email to

[Prev in Thread] Current Thread [Next in Thread]