Fwd: Coreutils tail.c fixes

[Grigoriy Sokolik]

I've tried to find out how to send a PR. So it seems that the easiest way
is to send a patch by email. So here is it in the attachment.

Thanks!
Best regards,
Grigorii


---------- Forwarded message ---------
From: Pádraig Brady <P@draigbrady.com>
Date: Thu, 15 Oct 2020 at 15:54
Subject: Re: Coreutils tail.c fixes
To: Grigoriy Sokolik <g.sokol99@g-sokol.info>


On 15/10/2020 12:06, Grigoriy Sokolik wrote:
> Sorry for annoying you.
> I made some test and not sure what else could be done:
>
> ### Terminal 1                                       | ### Terminal 2
> $ mkdir foo_a foo_b                                  |
> $ echo 'foo_a' > foo_a/test                          |
> $ echo 'foo_b' > foo_b/test                          |
> $ tail --follow=name foo_a/test foo_b/test           |
> ==> foo_a/test <==                                   |
> foo_a                                                |
>                                                       |
> ==> foo_b/test <==                                   |
> foo_b                                                |
>                                                       |
>                                                       | # Checking it
actually works:
>                                                       | $ echo
'foo_a_new' >> foo_a/test
> ==> foo_a/test <==                                   |
> foo_a_new                                            |
>                                                       | $ mkdir foo_c
>                                                       | $ echo 'foo_c' >
foo_c/test
>                                                       | rm -rf foo_a
> tail: foo_a/test: No such file or directory          |
> tail: directory containing watched file was removed  |
> tail: inotify cannot be used, reverting to polling   |
>                                                       | mv foo_c foo_a
> tail: 'foo_a/test' has appeared;  following new file |
>                                                       |
> ==> foo_a/test <==                                   |
> foo_c                                                |
>                                                       |
>
> So, I mean, currently, that's already handling the file appeared again.

The FIXME comment was added in:
https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.5-191-g61b77891c

while the fix (albeit not using inotify) was added in:
https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=v8.27-21-gba5fe2d4b

So we should remove that FIXME comment now.

cheers,
Pádraig

tail.c.patch
Description: Text Data