coreutils
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Having 'cat' use copy_file_range


From: Pádraig Brady
Subject: Re: Having 'cat' use copy_file_range
Date: Fri, 28 Jan 2022 15:05:50 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:95.0) Gecko/20100101 Thunderbird/95.0

On 28/01/2022 01:22, Paul Eggert wrote:
cp+install+mv started using copy_file_range in coreutils 9.0 and it
seems to be working OK, so I thought I'd change cat to use it too. While
looking into that I found some infelicities and/or unlikely integer
overflows to fix (of course there are more where these came from; these
are just the ones having to do with page-aligned buffer allocation which
is something cat does).

I installed the attached series of patches to do all that; the last
patch is the copy_file_range change.

Thanks for doing all that.
Changes look good from a quick scan.

I might update NEWS to say _why_ copy_file_range is used
(copy acceleration (copy offload + maybe reflink)).

There is a new syntax-check failure, which I fixed up in gnulib with:
https://git.savannah.gnu.org/gitweb/?p=gnulib.git;a=commit;h=a3e1e74e

thanks,
Pádraig



reply via email to

[Prev in Thread] Current Thread [Next in Thread]