[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: fstatat + AT_NO_AUTOMOUNT

From: Paul Eggert
Subject: Re: fstatat + AT_NO_AUTOMOUNT
Date: Wed, 9 Mar 2022 15:47:29 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0

I audited gnulib's uses of fstatat and found one fishy one that doesn't use AT_NO_AUTOMOUNT, namely, in fts.c where the follow-symlink branch uses 'stat' whereas the no-follow-symlink branch uses fstatat without AT_NO_AUTOMOUNT. I installed the first patch to cause it be consistent in using AT_NO_AUTOMOUNT, which is also consistent with what glibc does (though this doesn't necessarily mean it's right - perhaps fts should have a new flag to control automounts, depending on what the user wants).

The second attached patch deprecates statat and lstatat, due to the confusion already mentioned.

I haven't audited Gnulib's uses of 'stat' and 'lstat'.

Attachment: 0001-fts-be-consistent-about-AT_NO_AUTOMOUNT.patch
Description: Text Data

Attachment: 0002-statat-now-obsolete.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]