Re: PATCH: fix bug in getdirs

[Jacob Bachmeyer]

Ben Elliston wrote:
> I've also added a getdirs test case which passes:
>
> diff --git a/testsuite/runtest.all/utils.test b/testsuite/runtest.all/utils.test
> index 107e907..2bf4869 100644
> --- a/testsuite/runtest.all/utils.test
> +++ b/testsuite/runtest.all/utils.test
> @@ -37,6 +37,10 @@ run_tests [subst {
>        {[file join ${srcdir} runtest.all topdir]}
>         "*topdir*subdir\[12\]*topdir*subdir\[12\]"
>         "getdirs toplevel, two subdirs" }
> +    { lib_pat_test getdirs
> +       {[file join ${srcdir} runtest.all nothere]}
> +       ""
> +       "getdirs toplevel, non-existent subdir"}
>  }]
>
>  # Test relative_filename:
>   

Looks good to me.  While you are in utils.test, you might want to do "s/ 
${srcdir} / $srcdir /" and similar if you prefer to get rid of 
make-style variable substitutions.


-- Jacob