[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: PATCH: fix bug in getdirs

From: Jacob Bachmeyer
Subject: Re: PATCH: fix bug in getdirs
Date: Sun, 09 Dec 2018 18:52:27 -0600
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090807 MultiZilla/ SeaMonkey/1.1.17 Mnenhy/

Ben Elliston wrote:
I've also added a getdirs test case which passes:

diff --git a/testsuite/runtest.all/utils.test b/testsuite/runtest.all/utils.test
index 107e907..2bf4869 100644
--- a/testsuite/runtest.all/utils.test
+++ b/testsuite/runtest.all/utils.test
@@ -37,6 +37,10 @@ run_tests [subst {
       {[file join ${srcdir} runtest.all topdir]}
        "getdirs toplevel, two subdirs" }
+    { lib_pat_test getdirs
+       {[file join ${srcdir} runtest.all nothere]}
+       ""
+       "getdirs toplevel, non-existent subdir"}

 # Test relative_filename:

Looks good to me. While you are in utils.test, you might want to do "s/ ${srcdir} / $srcdir /" and similar if you prefer to get rid of make-style variable substitutions.

-- Jacob

reply via email to

[Prev in Thread] Current Thread [Next in Thread]