[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PING][PATCH 0/3] GNAT test suite fixes for build sysroot
|
From: |
Arnaud Charlet |
|
Subject: |
Re: [PING][PATCH 0/3] GNAT test suite fixes for build sysroot |
|
Date: |
Thu, 20 Jun 2019 17:14:10 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
> > Have you resolved your copyright assignment issues since then?
>
> The ball is now in FSF's court I'm told.
OK
> > The above patch needs to use "or else" instead of "or". OK with this change
> > on the above patch.
>
> OK, I have updated that in my patch.
>
> Technically both variants of the expression achieve the same effect here
> as there is no problem with evaluating both sides of the OR operation in
> all cases, but your suggestion might help the readers avoid scratching
> their heads.
The performance isn't the same, and more importantly, this is the documented
Ada coding style for GNAT:
https://gcc.gnu.org/onlinedocs/gnat-style/Statements.html#Statements
Arno