denemo-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Denemo-devel] The rhythm/pitch overlay patch.


From: Richard Shann
Subject: [Denemo-devel] The rhythm/pitch overlay patch.
Date: Thu, 13 Sep 2007 18:15:52 +0100

A few notes on this patch might help.

1) I have included a Changelog entry to describe the changes

2) I have changed the .y and .c files to correspond, but cannot
guarantee them as although the .po bug that prevented me building has
gone I now can't build because the configure step says it can't find my
libxml!

3) There may be one or two places remaining in the sources where notes
are referred to as "tones", the idea is to remove these entirely so that
we have a consistent terminology

4) One headache was caused by the lack of a structure in the denemo
source code for a measure: this means that the code cannot easily be
extended to add a property to a measure. One possible way of developing
the code would be to define the measurenode structure with the property
that it has fields next,prev and data which correspond to those of the
GList structure. Extra fields could be added at the end. The danger
would be if someone has used sizeof(GList) rather than
sizeof(measurenode) etc. As it is the tones that are attached to a
measure are sitting in a list of lists making a sort of ladder structure
with the measures.

I've been through the patch with care, and I don't believe there are any
regressions, but I am puzzled why Jeremiah's build from CVS should have
failed as the #ifdef USE_LOCAL_DENEMOUI is correct in CVS...
Also I reported a regression before, but I didn't see any traffic fixing
it (it was one of the api function changes).

Richard






reply via email to

[Prev in Thread] Current Thread [Next in Thread]