Re: [Denemo-devel] gub patches applied

[Jeremiah Benham]

On Thu, 30 Jul 2009 22:08:14 +0100
Richard Shann <address@hidden> wrote:

> autogen.sh complains about line 61, taking out the stray # sign I get
> 
> src/Makefile.am
> 
> -DLOCALEDIR=\"$(localedir)\" \
> -DSYSCONFDIR=\"$(sysconfdir)/\" \
> -DPKGDATADIR=\"$(pkgdatadir)/\" \
> -DDATAROOTDIR=\"$(datarootdir)/\" \
> -DPKGNAME=\"denemo\" 
> 
> but this generates...
> 
> src/Makefile.in
> -DLOCALEDIR=\"$(localedir)\" \
> -DSYSCONFDIR=\"$(sysconfdir)/\" \
> -DPKGDATADIR=\"$(pkgdatadir)/\"
> 
> which generates
> src/Makefile
> 
> -DLOCALEDIR=\"$(localedir)\" \
> -DSYSCONFDIR=\"$(sysconfdir)/\" \
> -DPKGDATADIR=\"$(pkgdatadir)/\"
> 
> the last two are missing the PKGNAME
> why I can't imagine...

Did your run ./autogen.sh and ./configure ?  grep the Makefile for
PKGNAME afterwards. 

> I notice the first line of these quotes has 
> localedir)\" \
> 
> while the others have an extra /
> sconfdir)/\" \

This is like stating "/usr/local" vs. "/usr/local/"

My src/Makefile has (after ./autogen; ./configure --enable-jack
--enable-lash):

INCLUDES = -I../intl -I$(top_srcdir)/intl -I$(top_srcdir)/include \
-I$(top_srcdir)/libsmf \
-I$(top_srcdir)/pixmaps \
-DLOCALEDIR=\"$(localedir)\" \
-DSYSCONFDIR=\"$(sysconfdir)/\" \
-DPKGDATADIR=\"$(pkgdatadir)/\" \
-DDATAROOTDIR=\"$(datarootdir)/\" \
-DPKGNAME=\"denemo\"


> but I don't know what language we are in here...

Its Bash. <sarcasm> Isn't it Lovely? </sarcasm> 
I often considered adding support so that denemo could be build
by scons. Scons uses python to manage the building process. IIRC it
was clearer to read. There was never enough motivation to switch
though. If its not broke .... 

Jeremiah


> 
> Richard
> 
> 
> 
> 
> On Thu, 2009-07-30 at 13:41 -0500, Jeremiah Benham wrote:
> > I applied the patches in gub and pushed it to git.
> > 
> > Jeremiah
> > 
> > 
> > _______________________________________________
> > Denemo-devel mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/denemo-devel
>