Re: [Denemo-devel] SOC - remarks 3 [FIX]

[Ralf Mattes]

On Thu, 04 Aug 2011 21:38:39 +0200, Dominic Sacré wrote:

> On Thursday 04 August 2011 21:06:16 Ralf Mattes wrote:
>> On Thu, 04 Aug 2011 19:00:51 +0000, Ralf Mattes wrote:
>> > Another little buglet: during playback, two notes are highlighed, the
>> > one playing and the one before.
>> 
>> Found it: the call to gtk_main() should be protected by
>> gdk_thread_enter/leave I've fixed that in view.c (will be commited to
>> soc). BTW, I'd rather prefer that gtk_init happens within that
>> protection as well, but unfortunately that function is called in main
>> instead of inner main. This should be cleaned up soon.
> 
> Interesting... I had been experimenting with this, but it didn't seem to
> help 

Well, it doesn't fix the problem. 

> (and the GTK documentation is pretty vague about these things).

>From all I understand gtk_main should/must be protected. It doesn't hurt
and it might save us some trouble later on iff we want/need more than one
thread accessing queues/gdk.

>  In
> fact, even the master branch of Denemo, which is essentially single-
> threaded (!), sometimes exhibited this double-playhead issue as well.
> I'll see if I can still reproduce it...

Yes, I seem to recall that too. 

 Cheers, RalfD

> 
> Dominic