denemo-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Denemo-devel] [bug #40911] MIDI instrument list is not correct


From: anonymous
Subject: [Denemo-devel] [bug #40911] MIDI instrument list is not correct
Date: Sun, 22 Dec 2013 10:52:53 +0000
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:26.0) Gecko/20100101 Firefox/26.0

Follow-up Comment #1, bug #40911 (project denemo):

I have looked into this, and found that the problem seems to be that the sf2
presets are stored in arbitrary order, not sequentially. Each preset header
carries the preset name, preset number(this is what you want to sort by) and
bank number.

I've tried to come up with a patch for this but it's a bit over my head, and
my C skills seem to have become rusty. I extended the ParseSoundfont function
to also return the bank number, and currently sort only those presets that are
on bank 0, by looking at the preset number and using g_list_insert() instead
of g_list_append(), and throw away everything else. For some reason I fail to
understand currently, the sorting still doesn't work as it should, I hope
someone can investigate. I'm not sure about the code in set_properties (struct
callbackdata *cbdata), which also calls ParseSoundfont(), I haven't seen it
running in gdb during my tests but I may have missed something.

I append a git diff with my changes against current master.

Edgar

(file #30063)
    _______________________________________________________

Additional Item Attachment:

File name: denemo-sf2_presetlist.diff     Size:3 KB


    _______________________________________________________

Reply to this item at:

  <http://savannah.gnu.org/bugs/?40911>

_______________________________________________
  Nachricht gesendet von/durch Savannah
  http://savannah.gnu.org/




reply via email to

[Prev in Thread] Current Thread [Next in Thread]