[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Discuss-gnuradio] Small cleanups for inband code

From: George Nychis
Subject: Re: [Discuss-gnuradio] Small cleanups for inband code
Date: Wed, 28 Jan 2009 15:46:14 -0500
User-agent: Thunderbird (X11/20090105)

Stefan Bruens wrote:
One more: This time, some changes for the uniform vectors (uv) of pmt.
Rationale: std::vector<> always initializes memory.
First, for the uvs, uninitialized may be fine for many cases, otherwise, initialization should be requested explicitly. Second, even for scalar types, initialization is expensive, as memset is only used for byte sized types, otherwise a for loop is used (even when setting to 0).

This patch introduces a small helper class which substitutes std::vector for the uniform vectors.

This patch has no influence on ABI/API.

It saves about 20% of cycles for test_usrp_inband_tx. (Savings for *_rx are much smaller, as it only uses uv_u8, not uv_s16, but still significant)

Awesome, thanks as usual. Getting around to this... one thing though, I think you forgot to include the patch :)

- George

reply via email to

[Prev in Thread] Current Thread [Next in Thread]