[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Discuss-gnuradio] grc should warn, not fail with malformed xml

From: Josh Blum
Subject: Re: [Discuss-gnuradio] grc should warn, not fail with malformed xml
Date: Fri, 03 Apr 2009 08:32:50 -0700
User-agent: Thunderbird (X11/20090318)

lxml.etree.XMLSyntaxError: Opening and ending tag mismatch: doc line
23 and block, line 29, column 9

Josh, shouldn't GRC ignore malformed xml files (or maybe warn),
instead of failing to run?
Sorry, I am not yet familiar enough to submit a patch for this...

It was intentional. If the block definition is bad, it prints out the problem and exits. The other possibility is to print the error, not parse that block which contained the error, and continue loading.

My worry was that if somebody (including myself) makes a bad block, the error would be missed or overlooked when the program opens, so rather, it just exits with error.

Any strong opinions on this (error vs warn)? Either way is ok with me, I just want it to be most useful for the majority of users.


Dimitris Symeonidis
"If you think you're too small to make a difference, try sleeping with
a mosquito!" - Amnesty International

Discuss-gnuradio mailing list

reply via email to

[Prev in Thread] Current Thread [Next in Thread]