[Discuss-gnuradio] GRC: wrong input declaration in sample_and_hold

[Alberto Trentadue]

Hello

I think I found a wrong input declaration in the sample_and_hold GRC block.
The "control" input is defined to be 
of the same data type of "in" and "out". Instead, it should be a byte.

This is the fix I have applied:


address@hidden gnuradio]$ diff -c 
./share/gnuradio/grc/blocks/gr_sample_and_hold_xx.xml.orig .
/share/gnuradio/grc/blocks/gr_sample_and_hold_xx.xml
*** ./share/gnuradio/grc/blocks/gr_sample_and_hold_xx.xml.orig  
2010-05-28 23:29:32.953460291 +0200
--- ./share/gnuradio/grc/blocks/gr_sample_and_hold_xx.xml       2010-05-28 
23:29:
57.655461060 +0200
***************
*** 40,46 ****
        </sink>
        <sink>
                <name>ctrl</name>
!               <type>$type</type>
        
</sink>
        <source>
                <name>out</name>
--- 40,46 ----
        </sink>
        <sink>
                <name>ctrl</name>
!               
<type>byte</type>
        </sink>
        <source>
                <name>out</name>

BTW: what is the need to use a "char" as control in the 
correspondent gr block?

Moreover, it seems to me that the Documentation is wrong, because the block 
samples the input 
when the ctrl is 1, and holds when is 0, not the opposite.
Do you agree?

Alberto-


Risparmia con Tutto Incluso Light: telefono + adsl 8 mega a soli 14,95 € al 
mese.

Gratis la Sim Tiscali Mobile con 25 euro di traffico! 

L'offerta è valida solo se attivi entro il 03/06/10

http://abbonati.tiscali.it/telefono-adsl/prodotti/tc/tuttoincluso_light/?WT.mc_id=01fw