[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Discuss-gnuradio] Xlate FIR filter broken in gr 3.7

From: Johnathan Corgan
Subject: Re: [Discuss-gnuradio] Xlate FIR filter broken in gr 3.7
Date: Thu, 08 Aug 2013 13:14:04 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130623 Thunderbird/17.0.7

On 08/08/2013 01:01 PM, Andrew Davis wrote:

> It's not just you, I noticed this too. This change broke gr-atsc ( but I
> fixed that ). 
> The problem is on line 80 of
> gr-filter/lib/freq_xlating_fir_filter_XXX_impl.cc.t: the 2 was not
> negative in 3.6 but is now, i'm not sure why.

Good catch, thanks.

The "old style" version of the block in gnuradio-core in works
correctly.  The "new style" version of the block in gr-filter in
has the sign change.  When all the old-style blocks were removed for
3.7, this of course left only the changed one.

Since it was Tom who did the conversion on that block, I'll wait until
he chimes in on whether his change was an accident or intentional.

Johnathan Corgan, Corgan Labs
SDR Training and Development Services
Visit us at GRCON13 Oct. 1-4 http://ow.ly/ntmpL

Attachment: signature.asc
Description: OpenPGP digital signature

reply via email to

[Prev in Thread] Current Thread [Next in Thread]