Re: [Discuss-gnuradio] Bug in fmdet_cf_impl.cc

[Ben Hilburn]

Hi Eugene -

Wow, yeah - that one is pretty egregious. I see you actually first reported the bug in February of 2014. Sorry it fell through the cracks!

I have created a PR with this fix and submitted it against `maint`.

Cheers,

Ben

On Tue, Jul 12, 2016 at 8:53 PM, Eugene Grayver <address@hidden> wrote:

There's an obvious bug in the very old fmdet_cf_impl.cc file.  I reported it before, but it has not been fixed.  Unfortunately I can't do a pull request, so somebody please fix it:

fmdet_cf_impl.cc:109

<<<Sdot = d_scl * (-S0+d_8*S1-d_8*S1+S4);

>>>Sdot = d_scl * (-S0+d_8*S1-d_8*S2+S4);

Note that the third term should be S2, not S1.  Otherwise, terms 2 and 3 just cancel each other.

________________________

Eugene Grayver, Ph.D.
Aerospace Corp., Sr. Eng. Spec.
Tel: 310.336.1274
________________________

_______________________________________________
Discuss-gnuradio mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/discuss-gnuradio