Re: Compilation of Ron Economos' gr-dvbtx for GNU Radio 3.8 - help needed

[Ron Economos]

That's the correct fix for 3.7. The person I originally wrote that 
module for was running 3.7.9.1, and I added a commit to handle that.

https://github.com/drmpeg/gr-dvbtx/commit/dbe40793fea88e2310881582639cb4be60dd926b

For 3.8, the module needs to be updated. It takes more than just 
modifying CMakeLists.txt. I'll do that later today.

BTW, you would usually file an issue on the Github repository for these 
kind of things, instead of here on discuss-gnuradio.

Ron

On 3/22/21 13:06, Ralf Gorholt wrote:
> Dear all,
>
> I have tried to compile Ron Economs’ block gr-dvbtx from
> github.com/drmpeg/gr-dvbtx for GNU Radio 3.7.11 and 3.8.2 but I have
> noticed several problems.
>
> 1) In both environments compilation stops because of an error:
> "gr-dvbtx/lib/dvbtx_ofdm_sym_acquisition_impl.cc:54:68: error: cannot
> convert ‘uint32_t* {aka unsigned int*}’ to ‘uint16_t* {aka short
> unsigned int*}’ in argument passing volk_32f_index_max_16u(&peak_index,
> &datain[0], datain_length);"
>
> In order to be able to compile the module, I have declared peak_index as
> uint16_t but I don’t know if this is the correct way to get rid of this
> error. For GNU Radio 3.7 everything seems ok now. The module is compiled
> and appears in the list of modules of GNU Radio Companion. Is this
> correction ok?
>
> 2) CMakeLists.txt expects GNU Radio version 3.7.2:
> "find_package(Gnuradio "3.7.2" REQUIRED)". In order to compile for
> version 3.8.2, I had to adapt this line.
>
> 3) Now I can compile the module for GNU Radio 3.8, but after "make
> install" and "ldconfig", GNU Radio Companion does not show the module in
> the list. Install prefix is /usr. I have noticed that the compiled
> module for version 3.7 has a version information in the name:
> "libgnuradio-dvbtx-1.0.0git.so.0.0.0" but the one for version 3.8 has
> not: "libgnuradio-dvbtx-...so.0.0.0". Could this be the reason for the
> problem? The version is set in CMakeLists.txt. Why is it empty when
> compiled for version 3.8?
>
> Could somebody please give me a hint what I have to do to get this
> module compiled and installed for GNU Radio 3.8? I would like to use it
> on a more recent version of GNU Radio than 3.7.
>
> Thank you very much for your help!
>
> Kind regards,
>
> Ralf