Re: AppIcon patch revised...

[Richard Frith-Macdonald]

On Tuesday, February 6, 2001, at 02:47 PM, Sungjin Chun wrote:

> Hi,  
> Again I modified my patch. Previous one has the  
> problem; Appicon sometimes does not correctly 
> displayed. This is fixed in this newer one. 
> And this time I've separated gui part and xgps 
> part and real modification from previous one is 
> in the xgps part. Please look into the patch and 
> any comments are welcome as always. 


I've been looking at this stuff, and trying to figure out how it's supposed
to work (and more importantly ... why I can't get a heavily modified version
working).

A few things ...

The gui library patch shouldn't be necessary - the gui library already calls
the correct backend routines to make an appicon window.

The API already exists for creating an appicon ... you create the window and
then set its style - DPSwindow to create the window, then DPSstylewindow to
set the window style (to NSIconWindowMask in this case)

There is no need to add the is_iconwindow flag to the window structure, since 
this
information is carried in the existing win_attrs.window_style mask.


I've tried to merge modified versions of your patch into the latest lot of 
changes
I've made to the xgps code ... unfortunately, it doesn't seem to work :-)