[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: text system patch

From: Nicola Pero
Subject: Re: text system patch
Date: Fri, 13 Sep 2002 09:00:51 +0100 (BST)

Sorry to get back to you so late

> I've made some fix on the various text system classes and I would like to 
> receive comments on what I have done before I commit those fixes on CVS. 
> (I'd like to commit soon, 'cause i've made changes in Gorm that depends on 
> it)
> What is now fixed :
> -insertion point position is correct for left/center/right alignment
> -selection display is also correct for all alignment
> -insertion point blinking is better

I'm not quite sure why you call -_blink: (which does an immediate
-display) directly from -updateInsertionPointAndRestartTimer:.

This will generate calls to -display in the middle of nowhere.  For
example, calling -setEditable:YES on any textview will cause an immediate

I think -_blink: instead should only be called by a timer (this is why
it's calling -display directly, because it's assuming a timer has called

Calling -display on a widget everytime something is changed in a widget is
horribly inefficient - we want instead to do all updates of the widgets
without any calls to -display, and marking the appropriate rectangles as
needing display, and then have the next step in the run loop display only
once and for all all rectangles needing redisplay in a single call.  The
whole display engine is setup to support this and to be used in this way.

So you likely want to fix this problem.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]