[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Another NSDocument patch
From: |
Fred Kiefer |
Subject: |
Re: Another NSDocument patch |
Date: |
Wed, 07 Mar 2007 15:39:19 +0100 |
User-agent: |
Thunderbird 1.5.0.9 (X11/20060911) |
Commited.
Thank you for this patch
Fred
Wolfgang Lux wrote:
> Hello!
>
> The following patch brings NSDocument's modal print dialog interface
> into operation. Here's a short summary of the changes:
>
> - NSPrintPanel:
> The modal loop which displays the print panel is now left with either
> NSOKButton or NSCancelButton (cf. the documentation of NSPrintPanel's
> -runModal: and
>
> -beginSheetWithPrintInfo:modalForWindow:delegate:didEndSelector:contextInfo:
>
> methods).
>
> - NSPrintOperation:
> The callback passed to the print panel's beginSheet... method had a
> wrong signature (and also was misspelled). In addition, the code of
> the callback did retrieve its own callback from the print dictionary
> in a wrong way (was asking for a pointer to a selector while a
> selector was saved).
>
> - NSDocument:
> The callback of
> -runModalPrintOperation:delegate:didRunSelector:contextInfo:
> method has a different signature than the one passed to the print
> operation's
> -runOperationModalForWindow:delegate:didRunSelector:contextInfo:
> method. This
> means NSDocument needs some adapter code and also has to save the
> delegate
> and selector passed to runModalPrintOperation... in some place. Since
> there
> can be at most one print dialog for a document, I've chosen to add two
> private
> instance variables to NSDocument for that purpose.
>
> Regards
> Wolfgang
>
>
> ------------------------------------------------------------------------
>
> _______________________________________________
> Discuss-gnustep mailing list
> Discuss-gnustep@gnu.org
> http://lists.gnu.org/mailman/listinfo/discuss-gnustep